Remove build and doc references to Git submodules#8177
Merged
TravisEz13 merged 1 commit intoPowerShell:masterfrom Nov 5, 2018
Merged
Remove build and doc references to Git submodules#8177TravisEz13 merged 1 commit intoPowerShell:masterfrom
TravisEz13 merged 1 commit intoPowerShell:masterfrom
Conversation
Member
Author
|
Hi @TravisEz13! Good job folks getting rid of submodules, that's fantastic 🎉 |
3434a36 to
0561ef4
Compare
adityapatwardhan
previously requested changes
Nov 2, 2018
Member
adityapatwardhan
left a comment
There was a problem hiding this comment.
Thanks for this PR. Just 1 comment about the CHANGELOG.
Member
|
@andschwa Thanks for this PR! |
anmenaga
approved these changes
Nov 2, 2018
As of PowerShell#7892, the PowerShell repository no longer uses Git submodules. This is fantastic from a workflow standpoint, and so all the notes about how to deal with submodules (and all the build steps explicitly initializing and updating submodules) can be safely removed.
0561ef4 to
62d7b36
Compare
iSazonov
approved these changes
Nov 3, 2018
TravisEz13
approved these changes
Nov 5, 2018
Member
|
Thanks for your contribution |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
As of #7892, the PowerShell repository no longer uses Git submodules.
This is fantastic from a workflow standpoint, and so all the notes about
how to deal with submodules (and all the build steps explicitly
initializing and updating submodules) can be safely removed.
PR Summary
PR Checklist
.h,.cpp,.cs,.ps1and.psm1files have the correct copyright headerWIP:to the beginning of the title and remove the prefix when the PR is ready.[feature]if the change is significant or affects feature tests