Update license.rtf to only have major version#8127
Merged
TravisEz13 merged 1 commit intoPowerShell:masterfrom Oct 29, 2018
Merged
Update license.rtf to only have major version#8127TravisEz13 merged 1 commit intoPowerShell:masterfrom
TravisEz13 merged 1 commit intoPowerShell:masterfrom
Conversation
Collaborator
|
Why the file in RTF format? It is not readable in browser. Make sense to convert it to simple text (Utf-8)? |
Member
Author
|
@iSazonov this file is only shown in the MSI installer which requires RTF format |
anmenaga
approved these changes
Oct 26, 2018
anmenaga
left a comment
There was a problem hiding this comment.
Fixed typo in PR title: "license.tf" -> "license.rtf"
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR Summary
Guidance is that we can just have the major version at the top "PowerShell 6" and not worry about updating the minor version with each release. The change is on line 230. Word made the other changes to the RTF.
PR Checklist
.h,.cpp,.cs,.ps1and.psm1files have the correct copyright headerWIP:to the beginning of the title and remove the prefix when the PR is ready.[feature]if the change is significant or affects feature tests