Added updated photo of VScode due to new version of VScode#8084
Merged
TravisEz13 merged 12 commits intoPowerShell:masterfrom Oct 29, 2018
Merged
Added updated photo of VScode due to new version of VScode#8084TravisEz13 merged 12 commits intoPowerShell:masterfrom
TravisEz13 merged 12 commits intoPowerShell:masterfrom
Conversation
anmenaga
suggested changes
Oct 22, 2018
anmenaga
left a comment
There was a problem hiding this comment.
New photo was taken on a high-res screen, so when auto-scaled to the low-width boundaries of 'using-vscode.md' tutorial it will be unreadable.
For taking the screenshot please: 1) temporary drop the resolution of the screen 2) make sure that VS code window is relatively square (currently proposed image is twice as wide as it is tall).
PS. While you are at it, it would be great if you could double-check 'Editing with Visual Studio Code' instructions on 'using-vscode.md'. Are they still accurate on the latest VS Code version? Thanks.
Contributor
Author
|
Hi Andrew,
Thank you for your feedback.
I have replaced the photo, which make the scaling better.
It’s currently 1920x1080, which is more “square”. And by using the Preview function, I can see it fits the window.
Also, I went through the ‘using-vscode.md’, and I can confirm that it is still updated and relevant.
Best regards,
Lasse Hastrup
Fra: Andrew <notifications@github.com>
Sendt: Monday, October 22, 2018 10:37 PM
Til: PowerShell/PowerShell <PowerShell@noreply.github.com>
Cc: Lasse Hastrup <l@hastrup.me>; Author <author@noreply.github.com>
Emne: Re: [PowerShell/PowerShell] Added updated photo of VScode due to new version of VScode (#8084)
@anmenaga requested changes on this pull request.
New photo was taken on a high-res screen, so when auto-scaled to the low-width boundaries of 'using-vscode.md' tutorial it will be unreadable.
For taking the screenshot please: 1) temporary drop the resolution of the screen 2) make sure that VS code window is relatively square (currently proposed image is twice as wide as it is tall).
PS. While you are at it, it would be great if you could double-check 'Editing with Visual Studio Code' instructions on 'using-vscode.md'. Are they still accurate on the latest VS Code version? Thanks.
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub<#8084 (review)>, or mute the thread<https://github.com/notifications/unsubscribe-auth/Ap--SN1OLxmrzrw12w85wBSWlME3wRU9ks5uniyIgaJpZM4XwOwb>.
|
anmenaga
approved these changes
Oct 23, 2018
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR Summary
PR Checklist
.h,.cpp,.cs,.ps1and.psm1files have the correct copyright headerWIP:to the beginning of the title and remove the prefix when the PR is ready.[feature]if the change is significant or affects feature tests