Avoid using double quotes for constant strings in PowerShell#13328
Closed
xtqqczze wants to merge 1 commit intoPowerShell:masterfrom
Closed
Avoid using double quotes for constant strings in PowerShell#13328xtqqczze wants to merge 1 commit intoPowerShell:masterfrom
xtqqczze wants to merge 1 commit intoPowerShell:masterfrom
Conversation
Fix using new AvoidUsingDoubleQuotesForConstantString PSScriptAnalyzer rule
Member
|
@PowerShell/powershell-maintainers discussed this and concluded: This is an information rule. Purely an opinion, clearly by the number of changes required, we have not consensus. So, this rule should be considered, disabled. Furthermore, this PR should not be taken.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR Summary
Fix using new AvoidUsingDoubleQuotesForConstantString PSScriptAnalyzer rule
PR Context
PowerShell/PSScriptAnalyzer#1470
PR Checklist
.h,.cpp,.cs,.ps1and.psm1files have the correct copyright headerWIP:or[ WIP ]to the beginning of the title (theWIPbot will keep its status check atPendingwhile the prefix is present) and remove the prefix when the PR is ready.