Fix bug with PipelineIndentationStyle.None where break instead of continue statement was used#1497
Merged
bergmeister merged 7 commits intoPowerShell:masterfrom Jun 11, 2020
Merged
Conversation
…tinue statement was used. TODO: Fix test that starts to fail because of this now
This was referenced May 21, 2020
added 3 commits
June 11, 2020 21:00
… into issue1496 # Conflicts: # Tests/Rules/UseConsistentIndentation.tests.ps1
rjmholt
approved these changes
Jun 11, 2020
Co-authored-by: Robert Holt <rjmholt@gmail.com>
rjmholt
reviewed
Jun 11, 2020
| int searchLine; | ||
| do | ||
| { | ||
| searchLine = tokens[searchIndex].Extent.StartLineNumber; |
Contributor
There was a problem hiding this comment.
Oh! My switch suggestion got lost! Ugh, too much context switching... Anyway, not an issue
Collaborator
Author
There was a problem hiding this comment.
I thought I addressed your comment here by not initializing it: #1497 (comment)
Or did you mean a switch around tokens[searchIndex].Kind? I don't see too much value in it tbh. Switch statements don't look that much cleaner for simple cases like that IMHO because of their ceremony that requires additional indentation layer, break statements, etc..
Otherwise we can always create a follow up PR
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR Summary
Fixes #1496
Also added another test case that would've caught it.
PR Checklist
.cs,.ps1and.psm1files have the correct copyright headerWIP:to the beginning of the title and remove the prefix when the PR is ready.