Remove fuzzy string searching for scrolls of genocide#1480
Open
NateChoe1 wants to merge 2 commits intoNetHack:NetHack-3.7from
Open
Remove fuzzy string searching for scrolls of genocide#1480NateChoe1 wants to merge 2 commits intoNetHack:NetHack-3.7from
NateChoe1 wants to merge 2 commits intoNetHack:NetHack-3.7from
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Addresses issue #1474. I also created PR #1475 last month which handled this by adding a new
paranoid_confirmoption, although copperwater pointed out some concerns which have been implemented here.This PR disables fuzzy string searching for scrolls of genocide. For uncursed/cursed scrolls, strings like
master mnd flayer(which would eliminate monks) are no longer accepted because the monster name isn't the entire string. For blessed scrolls, strings likemaster mind flayerare no longer accepted because the monster name isn't a single letter or full class description.I changed the message "This [symbol/response] does not represent any monster" to "This [symbol/response] does not represent any monster class" because after this change it felt strange to have a response like
master mind flayer, which directly represents a monster, not represent a monster.