Make weaker artifacts less likely for better sacrifices#1443
Open
NDusN1 wants to merge 1 commit intoNetHack:NetHack-3.7from
Open
Make weaker artifacts less likely for better sacrifices#1443NDusN1 wants to merge 1 commit intoNetHack:NetHack-3.7from
NDusN1 wants to merge 1 commit intoNetHack:NetHack-3.7from
Conversation
Contributor
|
Seconded. This is something I've run into frequently in my recent 3.7 games, and it's very frustrating. |
Contributor
|
I like the change and also have frustrations at always using early-game artifacts for most of my ascension runs. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
It's weird that, with the current code, two sacrifice gifts meeting the same criteria has an equal chance of generating from a high-value sacrifice, which is noticeable from this short quote from #1429:
This PR makes it so that the chance of an artifact generating would be affected by its innate gift value versus max_giftvalue, the bigger the difference, the less the chance: a difference 10 or above would mean extremely unlikely.