WIP: Normalize similarities to [0, 1]#1095
Draft
edwinyyyu wants to merge 2 commits intoMemMachine:mainfrom
Draft
WIP: Normalize similarities to [0, 1]#1095edwinyyyu wants to merge 2 commits intoMemMachine:mainfrom
edwinyyyu wants to merge 2 commits intoMemMachine:mainfrom
Conversation
Signed-off-by: Edwin Yu <edwinyyyu@gmail.com>
296830b to
2ec6b4a
Compare
Signed-off-by: Edwin Yu <edwinyyyu@gmail.com>
malatewang
approved these changes
Feb 13, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Purpose of the change
Define common similarity/distance definitions.
Score threshold is currently defined as bigger is better, and the parameter is supposed to be overloaded instead of creating new parameters for different systems.
Supposedly users may be unwilling to understand the raw values.
Description
Define score formulas.
TODO:
Alternative:
Breaking:
Type of change
How Has This Been Tested?
Checklist
Maintainer Checklist