Fix AttributeError when executing empty or comment-only scripts #1303
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
result_status_msgbefore attempting to decodeIssue
Fixes #1259
When executing a PostgreSQL script that contains only comments (e.g.,
-- hello) or is empty, PostgreSQL returns no result status message. The code attempted to call.decode()onNone, causing anAttributeError.Changes
asyncpg/protocol/protocol.pyxto check ifresult_status_msgis not None before decodingtests/test_execute.pyto verify the fixTest plan
'-- hello')' ')'')This is a natural behavior where executing a script with only comments should be a no-op, which is useful when commenting out migration script contents during development.