feat: allow to pass cancellation token to requests#813
Merged
JohnnyCrazy merged 8 commits intoJohnnyCrazy:masterfrom Nov 18, 2022
Merged
feat: allow to pass cancellation token to requests#813JohnnyCrazy merged 8 commits intoJohnnyCrazy:masterfrom
JohnnyCrazy merged 8 commits intoJohnnyCrazy:masterfrom
Conversation
Owner
|
Thanks for the contribution! :) So I guess there is no...less verbose alternative and this is simply the standard when it comes to cancelling async requests with .NET/C#? |
Contributor
Author
|
I believe so. You have to pass the cancelation token through the chain of calls. Will try to resolve the conflicts on sunday. |
Owner
|
Fixed the conflicts and added one more passing of the cancelation token Def. huge thanks for the work! 👍🏼 will be included in the next release :) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hello,
to be able to cancel requests when necessary, I added a cancellation token to every request method and passed it down to the actual http client.
Hope this PR is in the interest of you and the other users.
Cheers,
esskar