Made mapping for all known table engines to a table types in JDBC#2737
Merged
Made mapping for all known table engines to a table types in JDBC#2737
Conversation
Client V2 CoverageCoverage Report
Class Coverage
|
JDBC V2 CoverageCoverage Report
Class Coverage
|
JDBC V1 CoverageCoverage Report
Class Coverage
|
Client V1 CoverageCoverage Report
Class Coverage
|
jdbc-v2/src/main/java/com/clickhouse/jdbc/metadata/DatabaseMetaDataImpl.java
Outdated
Show resolved
Hide resolved
jdbc-v2/src/main/java/com/clickhouse/jdbc/metadata/DatabaseMetaDataImpl.java
Show resolved
Hide resolved
jdbc-v2/src/main/java/com/clickhouse/jdbc/metadata/DatabaseMetaDataImpl.java
Outdated
Show resolved
Hide resolved
jdbc-v2/src/main/java/com/clickhouse/jdbc/metadata/DatabaseMetaDataImpl.java
Show resolved
Hide resolved
kurnoolsaketh
requested changes
Feb 9, 2026
jdbc-v2/src/main/java/com/clickhouse/jdbc/metadata/DatabaseMetaDataImpl.java
Outdated
Show resolved
Hide resolved
jdbc-v2/src/main/java/com/clickhouse/jdbc/metadata/DatabaseMetaDataImpl.java
Show resolved
Hide resolved
jdbc-v2/src/main/java/com/clickhouse/jdbc/metadata/DatabaseMetaDataImpl.java
Outdated
Show resolved
Hide resolved
jdbc-v2/src/main/java/com/clickhouse/jdbc/metadata/DatabaseMetaDataImpl.java
Show resolved
Hide resolved
jdbc-v2/src/main/java/com/clickhouse/jdbc/metadata/DatabaseMetaDataImpl.java
Outdated
Show resolved
Hide resolved
jdbc-v2/src/main/java/com/clickhouse/jdbc/metadata/DatabaseMetaDataImpl.java
Outdated
Show resolved
Hide resolved
jdbc-v2/src/main/java/com/clickhouse/jdbc/metadata/DatabaseMetaDataImpl.java
Show resolved
Hide resolved
jdbc-v2/src/main/java/com/clickhouse/jdbc/metadata/DatabaseMetaDataImpl.java
Outdated
Show resolved
Hide resolved
…lumn name with constant
jdbc-v2/src/main/java/com/clickhouse/jdbc/metadata/DatabaseMetaDataImpl.java
Outdated
Show resolved
Hide resolved
jdbc-v2/src/main/java/com/clickhouse/jdbc/metadata/DatabaseMetaDataImpl.java
Show resolved
Hide resolved
Contributor
Author
|
the security issue will be addressed in #2739 |
kurnoolsaketh
approved these changes
Feb 13, 2026
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.


Summary
Closes #2664
Checklist
Delete items not relevant to your PR:
Note
Medium Risk
Changes core metadata queries and type filtering logic used by client tooling; incorrect mapping or filter predicates could hide tables or misclassify types across ClickHouse versions.
Overview
Improves
DatabaseMetaDatatable typing and filtering in JDBC v2. Adds a newMATERIALIZED VIEWtable type and introduces an explicitENGINE_TO_TABLE_TYPEmapping sogetTables()reports consistent JDBCTABLE_TYPEvalues for known ClickHouse engines (including remote/external engines), with sensible defaults for unknown engines.getTables()is reworked to filter by requested JDBC table types by translating them into engine predicates (plus special handling forSystem*/Async*engines and temporary tables), and it now usesPreparedStatement+ aDetachedResultSetmutator to post-process engine names into JDBC table types.getTableTypes()is also switched to a parameterized array-based query.Integration tests are expanded to (1) assert every engine in
system.table_enginesis mapped or covered by the system-engine prefixes, and (2) create representative objects (table/view/materialized view/remote/dictionary/etc.) to validate both unfiltered and type-filteredgetTables()behavior and the full set returned bygetTableTypes().Written by Cursor Bugbot for commit 59f87e9. This will update automatically on new commits. Configure here.