This repository was archived by the owner on Jan 17, 2023. It is now read-only.
ignore https check if baseURL is not set#4557
Open
mojtabacazi wants to merge 1 commit intoAFNetworking:masterfrom
Open
ignore https check if baseURL is not set#4557mojtabacazi wants to merge 1 commit intoAFNetworking:masterfrom
mojtabacazi wants to merge 1 commit intoAFNetworking:masterfrom
Conversation
Member
|
Thanks for the PR! I'm inclined to lift this restriction, but this PR doesn't go far enough in updating the logic. Please outline the conditions in which we should produce an error when applying a security policy and update the tests accordingly. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Goals ⚽
We should allow usage of security policy if URL construction is being managed outside of AFNetworking and not using
baseURLvariable.Implementation Details 🚧
Check usage of
httpsonly ifbaseURLis set. Otherwise assume it's user responsibility to use the right protocol.Testing Details 🔍
Tests are updated to validate new changes.