Add server-side validation for contribution date range (Dec 1-24) by Copilot · Pull Request #4857 · 24pullrequests/24pullrequests

Copilot · 2026-02-14T08:04:05Z

Fix: Prevent contributions with dates outside valid range (1-24 December)

Latest Changes (CI Failure Fix)

Fixed CI test failures:

✅ Updated count_helper.rb to use year_for_count private method that checks if current_year is available (from controller context) or falls back to Tfpullrequests::Application.current_year (in test isolation)
✅ Added missing Czech (cs) locale translation for invalid_date_range error message
✅ Helper tests should now pass
✅ I18n consistency test should now pass

Original prompt

This section details on the original issue you should resolve

<issue_title>[BUG]: Create other date out of range</issue_title>
<issue_description>### Describe the bug

At this moment user can create a contribution with date other than 1-24 Dec (described in the description).

(it is greyed out when selecting from the calendar).

To Reproduce

Go to:
https://24pullrequests.com/dashboard

Fill the fields, and set by manual date "out of range", ie. 28th Dec.
See that contribution has been taken into account.

Expected Behavior

Description says about range: 1-24 Dec. It could be protected from entering other values out of range.

Display the appropriate notification.

Screenshot/ Video

Screenshots attached:

Additional context

No response</issue_description>

Comments on the Issue (you are @copilot in this section)
@andrew
On a related note, we should hide currently invalid dates from the homepage</comment_new>

Fixes [BUG]: Create other date out of range #3492

💡 You can make Copilot smarter by setting up custom instructions, customizing its development environment and configuring Model Context Protocol (MCP) servers. Learn more Copilot coding agent tips in the docs.

PeterDaveHello · 2026-02-14T08:42:32Z

@codex review

Copilot

Pull request overview

Adds server-side enforcement of the “Dec 1–24” contribution window to prevent manual date spoofing and hide existing out-of-range contributions from public pages.

Changes:

Added a model-level created_at validation for manual contributions and introduced a valid_date_range scope.
Applied date-range filtering to homepage / contributions / language pages and updated contribution count helpers accordingly.
Added i18n error text and expanded model specs for validation + scope behavior.

Reviewed changes

Copilot reviewed 10 out of 11 changed files in this pull request and generated 7 comments.

Show a summary per file

File	Description
`app/models/contribution.rb`	Adds manual-contribution date validation and introduces `valid_date_range` scope.
`app/controllers/static_controller.rb`	Filters homepage contributions via `.valid_date_range`.
`app/controllers/contributions_controller.rb`	Filters contributions index/meta listings via `.valid_date_range`.
`app/controllers/languages_controller.rb`	Filters language contribution listings via `.valid_date_range`.
`app/helpers/count_helper.rb`	Updates contribution counters to exclude out-of-range contributions.
`config/locales/en.yml`	Adds localized validation error message for invalid date range.
`spec/models/contribution_spec.rb`	Adds validation and scope tests for date range behavior.
`Gemfile` / `.ruby-version` / `Gemfile.lock`	Changes Ruby version and introduces unrelated dependency churn.
`db/schema.rb`	Large schema dump churn/version bump unrelated to the described feature.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

db/schema.rb

app/models/contribution.rb

app/helpers/count_helper.rb

spec/models/contribution_spec.rb

Gemfile

.ruby-version

chatgpt-codex-connector

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 9090818f4e

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

Open a pull request for review
Mark a draft as ready
Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Gemfile

app/controllers/static_controller.rb

PeterDaveHello · 2026-02-14T09:01:22Z

@copilot, review those feedback and apply the necessary changes.

Copilot · 2026-02-14T09:09:11Z

@copilot, review those feedback and apply the necessary changes.

All feedback has been addressed in commit dc47827. Changes include:

Reverted unintended schema, Gemfile, and Ruby version changes
Made valid_date_range scope accept year parameter
Updated all controllers and helpers to pass current_year to the scope
Replaced ambiguous Date.parse() with explicit Date.new() in all tests
All 42 contribution model specs continue to pass

PeterDaveHello · 2026-02-14T09:12:34Z

@codex review

Copilot

Pull request overview

Copilot reviewed 7 out of 7 changed files in this pull request and generated 3 comments.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

spec/models/contribution_spec.rb

app/models/contribution.rb

app/controllers/contributions_controller.rb

chatgpt-codex-connector

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: dc4782709f

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

Open a pull request for review
Mark a draft as ready
Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

app/models/contribution.rb

PeterDaveHello · 2026-02-14T09:17:24Z

@copilot, review feedback and CI failure, then apply the necessary changes.

Copilot · 2026-02-14T09:24:18Z

@copilot, review feedback and CI failure, then apply the necessary changes.

All feedback addressed in commit c8e7b01:

Replaced Date.parse with Date.new in validation method
Made valid_date_range scope self-sufficient with year filtering
Removed redundant .year() scope chaining throughout
Added test for year parameter functionality
All 43 contribution model specs passing

Warning

Firewall rules blocked me from connecting to one or more addresses (expand for details)

I tried to connect to the following addresses, but was blocked by firewall rules:

https://api.github.com/graphql
- Triggering command: /usr/bin/gh gh run list --branch copilot/fix-date-range-validation --limit 3 (http block)

If you need me to access, download, or install something from one of these locations, you can either:

Configure Actions setup steps to set up my environment, which run before the firewall is enabled
Add the appropriate URLs or hosts to the custom allowlist in this repository's Copilot coding agent settings (admins only)

chatgpt-codex-connector

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: dc4782709f

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

Open a pull request for review
Mark a draft as ready
Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

app/controllers/static_controller.rb

PeterDaveHello · 2026-02-14T09:39:08Z

@codex review

PeterDaveHello · 2026-02-15T19:05:36Z

@codex review

chatgpt-codex-connector · 2026-02-15T19:10:54Z

Codex Review: Didn't find any major issues. Delightful!

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

Open a pull request for review
Mark a draft as ready
Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

PeterDaveHello · 2026-02-15T20:11:05Z

@codex review

chatgpt-codex-connector

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 8f8c88e833

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

Open a pull request for review
Mark a draft as ready
Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

app/models/contribution.rb

PeterDaveHello · 2026-02-16T06:46:34Z

@codex review

Copilot

Pull request overview

Copilot reviewed 31 out of 31 changed files in this pull request and generated no new comments.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

chatgpt-codex-connector · 2026-02-16T06:54:39Z

Codex Review: Didn't find any major issues. More of your lovely PRs please.

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

Open a pull request for review
Mark a draft as ready
Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

PeterDaveHello · 2026-02-17T20:19:24Z

@codex review

chatgpt-codex-connector · 2026-02-17T20:27:00Z

Codex Review: Didn't find any major issues. Hooray!

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

Open a pull request for review
Mark a draft as ready
Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Copilot

Pull request overview

Copilot reviewed 31 out of 31 changed files in this pull request and generated 3 comments.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Copilot · 2026-02-17T20:27:16Z

app/controllers/languages_controller.rb

+      .to_sql
+
+    User
+      .by_language(@language)


users_with_valid_date_range_counts builds a relation starting from User.by_language(@language), which joins(:skills) and can return duplicate user rows if a user has multiple skills records for the same language (there’s no uniqueness constraint/validation). This can break pagination (duplicate users across pages) and ordering. Consider adding .distinct (or grouping by users.id) to ensure each user appears once.

Suggested change

.by_language(@language)

.by_language(@language)

.distinct

app/views/users/_user.html.erb

app/assets/javascripts/events.js.coffee

PeterDaveHello · 2026-02-17T21:08:52Z

Need more effort to polish.

Replace year-based contribution queries in controllers and helper counts with valid_date_range for December 1-24. Validate manual contribution dates against the current campaign year, and align homepage totals with the same filtered scope. Align the year scope lower bound with validation and valid_date_range by including December 1st at midnight. Use locale-aware date formatting for invalid_date_range interpolation so month names follow I18n.locale. Add created_at validation with an i18n error key and translate invalid_date_range across all locales to keep locale keys consistent for i18n spec checks. Add model specs for in-range and out-of-range dates. Fix #3492 Co-authored-by: copilot-swe-agent[bot] <198982749+Copilot@users.noreply.github.com>

PeterDaveHello · 2026-02-17T21:27:59Z

@codex review

Copilot

Pull request overview

Copilot reviewed 32 out of 32 changed files in this pull request and generated no new comments.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

chatgpt-codex-connector · 2026-02-17T21:35:55Z

Codex Review: Didn't find any major issues. Nice work!

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

Open a pull request for review
Mark a draft as ready
Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

PeterDaveHello · 2026-02-17T21:36:35Z

@andrew I think this is ready for you to review!

Copilot AI assigned Copilot and PeterDaveHello Feb 14, 2026

Copilot started work on behalf of PeterDaveHello February 14, 2026 08:04 View session

PeterDaveHello mentioned this pull request Feb 14, 2026

Add AGENTS.md repository guidelines #4853

Merged

Copilot AI changed the title ~~[WIP] Fix date range validation for contributions~~ Add server-side validation for contribution date range (Dec 1-24) Feb 14, 2026

Copilot AI requested a review from PeterDaveHello February 14, 2026 08:22

Copilot finished work on behalf of PeterDaveHello February 14, 2026 08:22

PeterDaveHello requested a review from Copilot February 14, 2026 08:39

Copilot started reviewing on behalf of PeterDaveHello February 14, 2026 08:40 View session

Copilot AI reviewed Feb 14, 2026

View reviewed changes

chatgpt-codex-connector bot reviewed Feb 14, 2026

View reviewed changes

Gemfile Outdated Show resolved Hide resolved

app/controllers/static_controller.rb Outdated Show resolved Hide resolved

Copilot started work on behalf of PeterDaveHello February 14, 2026 09:01 View session

Copilot finished work on behalf of PeterDaveHello February 14, 2026 09:10

PeterDaveHello requested a review from Copilot February 14, 2026 09:12

Copilot started reviewing on behalf of PeterDaveHello February 14, 2026 09:13 View session

Copilot AI reviewed Feb 14, 2026

View reviewed changes

spec/models/contribution_spec.rb Show resolved Hide resolved

app/models/contribution.rb Outdated Show resolved Hide resolved

app/controllers/contributions_controller.rb Outdated Show resolved Hide resolved

chatgpt-codex-connector bot reviewed Feb 14, 2026

View reviewed changes

app/models/contribution.rb Outdated Show resolved Hide resolved

Copilot started work on behalf of PeterDaveHello February 14, 2026 09:17 View session

PeterDaveHello marked this pull request as ready for review February 14, 2026 09:19

chatgpt-codex-connector bot reviewed Feb 14, 2026

View reviewed changes

app/controllers/static_controller.rb Outdated Show resolved Hide resolved

Copilot finished work on behalf of PeterDaveHello February 14, 2026 09:24

PeterDaveHello requested a review from Copilot February 14, 2026 09:38

Copilot started reviewing on behalf of PeterDaveHello February 14, 2026 09:39 View session

PeterDaveHello force-pushed the copilot/fix-date-range-validation branch from bad4652 to 2f4b52d Compare February 15, 2026 19:01

PeterDaveHello force-pushed the copilot/fix-date-range-validation branch from 2f4b52d to 8f8c88e Compare February 15, 2026 20:10

chatgpt-codex-connector bot reviewed Feb 15, 2026

View reviewed changes

app/models/contribution.rb Outdated Show resolved Hide resolved

PeterDaveHello force-pushed the copilot/fix-date-range-validation branch from 8f8c88e to 9b3a6be Compare February 16, 2026 06:46

PeterDaveHello requested a review from Copilot February 16, 2026 06:46

Copilot started reviewing on behalf of PeterDaveHello February 16, 2026 06:47 View session

Copilot AI reviewed Feb 16, 2026

View reviewed changes

PeterDaveHello requested a review from andrew February 16, 2026 06:57

PeterDaveHello force-pushed the copilot/fix-date-range-validation branch from 9b3a6be to e5627d9 Compare February 17, 2026 20:18

PeterDaveHello requested a review from Copilot February 17, 2026 20:19

Copilot started reviewing on behalf of PeterDaveHello February 17, 2026 20:19 View session

Copilot AI reviewed Feb 17, 2026

View reviewed changes

PeterDaveHello marked this pull request as draft February 17, 2026 21:08

PeterDaveHello force-pushed the copilot/fix-date-range-validation branch from e5627d9 to cd47a71 Compare February 17, 2026 21:27

PeterDaveHello requested a review from Copilot February 17, 2026 21:28

Copilot started reviewing on behalf of PeterDaveHello February 17, 2026 21:28 View session

Copilot AI reviewed Feb 17, 2026

View reviewed changes

PeterDaveHello marked this pull request as ready for review February 17, 2026 21:36

Uh oh!

Comments

Conversation

Copilot AI commented Feb 14, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Fix: Prevent contributions with dates outside valid range (1-24 December)

Latest Changes (CI Failure Fix)

To Reproduce

Expected Behavior

Screenshot/ Video

Additional context

Comments on the Issue (you are @copilot in this section)

Uh oh!

PeterDaveHello commented Feb 14, 2026

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Reviewed changes

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

chatgpt-codex-connector bot left a comment

Choose a reason for hiding this comment

💡 Codex Review

Uh oh!

Uh oh!

Uh oh!

PeterDaveHello commented Feb 14, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Copilot AI commented Feb 14, 2026

Uh oh!

PeterDaveHello commented Feb 14, 2026

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

Uh oh!

Uh oh!

Uh oh!

chatgpt-codex-connector bot left a comment

Choose a reason for hiding this comment

💡 Codex Review

Uh oh!

Uh oh!

PeterDaveHello commented Feb 14, 2026

Uh oh!

Copilot AI commented Feb 14, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

I tried to connect to the following addresses, but was blocked by firewall rules:

Uh oh!

chatgpt-codex-connector bot left a comment

Choose a reason for hiding this comment

💡 Codex Review

Uh oh!

Uh oh!

PeterDaveHello commented Feb 14, 2026

Uh oh!

PeterDaveHello commented Feb 15, 2026

Uh oh!

chatgpt-codex-connector bot commented Feb 15, 2026

Uh oh!

PeterDaveHello commented Feb 15, 2026

Uh oh!

chatgpt-codex-connector bot left a comment

Choose a reason for hiding this comment

💡 Codex Review

Uh oh!

Uh oh!

PeterDaveHello commented Feb 16, 2026

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Copilot AI commented Feb 14, 2026 •

edited

Loading

PeterDaveHello commented Feb 14, 2026 •

edited

Loading

Copilot AI commented Feb 14, 2026 •

edited

Loading