File tree Expand file tree Collapse file tree 2 files changed +6
-6
lines changed
Expand file tree Collapse file tree 2 files changed +6
-6
lines changed Original file line number Diff line number Diff line change @@ -555,7 +555,7 @@ on Linux, you can try [Docker](https://www.docker.com/products/docker-desktop/)
555555(using an image like ` gengjiawen/node-build:2020-02-14 ` ).
556556
557557The ` --debug ` is not necessary and will slow down build and testing, but it can
558- show clear stacktrace if ASan hits an issue.
558+ show a clear stack trace if ASan hits an issue.
559559
560560``` bash
561561./configure --debug --enable-asan && make -j4
@@ -633,8 +633,8 @@ the number of parallel build tasks (`-j<n>`).
633633
634634#### Tips
635635
636- You may need disable vcpkg integration if you got link error about symbol
637- redefine related to zlib.lib(zlib1.dll), even you never install it by hand,
636+ You may need to disable vcpkg integration if you encounter a link error about symbol
637+ redefinition related to zlib.lib(zlib1.dll), even if you never installed it by hand,
638638as vcpkg is part of CLion and Visual Studio now.
639639
640640``` powershell
@@ -811,7 +811,7 @@ cp c:\ccache\ccache.exe c:\ccache\cl.exe
811811```
812812
813813With newer version of Visual Studio, it may need the copy to be ` clang-cl.exe `
814- instead. If the output of ` vcbuild.bat ` suggestion missing ` clang-cl.exe ` , copy
814+ instead. If the output of ` vcbuild.bat ` suggests missing ` clang-cl.exe ` , copy
815815it differently:
816816
817817``` powershell
Original file line number Diff line number Diff line change @@ -286,7 +286,7 @@ needs to be pointed out separately during the onboarding.
286286* If you are interested in helping to fix coverity reports consider requesting
287287 access to the projects coverity project as outlined in [ static-analysis] [ ] .
288288* If you are interested in helping out with CI reliability, check out the
289- [ reliability respository ] [ ] and [ guide on how to deal with CI flakes] [ ] .
289+ [ reliability repository ] [ ] and [ guide on how to deal with CI flakes] [ ] .
290290
291291[ Code of Conduct ] : https://github.com/nodejs/admin/blob/HEAD/CODE_OF_CONDUCT.md
292292[ Labels ] : doc/contributing/collaborator-guide.md#labels
@@ -299,7 +299,7 @@ needs to be pointed out separately during the onboarding.
299299[ `node-test-pull-request` ] : https://ci.nodejs.org/job/node-test-pull-request/
300300[ guide on how to deal with CI flakes ] : https://github.com/nodejs/test?tab=readme-ov-file#protocols-in-improving-ci-reliability
301301[ participants' expenses ] : https://github.com/openjs-foundation/cross-project-council/blob/main/community-fund/COMMUNITY_FUND_POLICY.md#community-fund-rules
302- [ reliability respository ] : https://github.com/nodejs/reliability
302+ [ reliability repository ] : https://github.com/nodejs/reliability
303303[ set up the credentials ] : https://github.com/nodejs/node-core-utils#setting-up-github-credentials
304304[ static-analysis ] : doc/contributing/static-analysis.md
305305[ two-factor authentication ] : https://help.github.com/articles/securing-your-account-with-two-factor-authentication-2fa/
You canβt perform that action at this time.
0 commit comments