feat: Support bool and bytes types in describe(include='all')#994
Merged
feat: Support bool and bytes types in describe(include='all')#994
Conversation
tswast
reviewed
Sep 18, 2024
bigframes/dataframe.py
Outdated
| ) | ||
| else: | ||
| # Otherwise, only describe numerical columns | ||
| result = numeric_df.agg(self._NUMERICAL_DISCRIBE_AGGS) |
Collaborator
There was a problem hiding this comment.
Might be worth fixing this typo in this PR DISCRIBE -> DESCRIBE
bigframes/dataframe.py
Outdated
| ) | ||
| return DataFrame(pivot_block) | ||
|
|
||
| def _filter_columns_by_type(self, types: Set[bigframes.dtypes.Dtype]) -> DataFrame: |
Collaborator
There was a problem hiding this comment.
Rather than create a private function for this, let's instead implement select_dtypes and use that.
Contributor
Author
There was a problem hiding this comment.
It turned out that select_dtypes() is already implemented in BF. Code updated.
tswast
approved these changes
Sep 19, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.