Conversation
tswast
commented
Aug 27, 2024
| ## dtype predicates - use these to maintain consistency | ||
| def is_datetime_like(type: ExpressionType) -> bool: | ||
| return type in (DATETIME_DTYPE, TIMESTAMP_DTYPE) | ||
| def is_datetime_like(type_: ExpressionType) -> bool: |
Collaborator
Author
There was a problem hiding this comment.
type is a built-in. Avoid conflicts by using type_.
single_trailing_underscore_: used by convention to avoid conflicts with Python keyword
https://peps.python.org/pep-0008/#descriptive-naming-styles
In this case, type is a function, not a keyword, so not strictly needed, but type is a common enough function that it is best to avoid conflicts, IMO.
shobsi
approved these changes
Aug 28, 2024
shobsi
reviewed
Aug 28, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We explicitly use the numpy module, so it should be an explicit dependency in
setup.py. Also, make sure we test with the minimum supported version by setting the minimum version in the constraints file (see: googleapis/synthtool#1901 and googleapis/python-test-utils#8).Thank you for opening a Pull Request! Before submitting your PR, there are a few things you can do to make sure it goes smoothly:
Fixes #687 🦕