docs: create sample notebook to manipulate struct and array data#883
docs: create sample notebook to manipulate struct and array data#883chelsea-lin merged 3 commits intomainfrom
Conversation
|
Check out this pull request on See visual diffs & provide feedback on Jupyter Notebooks. Powered by ReviewNB |
cc209e0 to
ccb8f48
Compare
| @@ -0,0 +1,658 @@ | |||
| { | |||
There was a problem hiding this comment.
Line #2. adj_scores_arr = bbq.array_agg(adj_scores.groupby(level=0))
Could we add a note about ordering? Is the original order preserved? If so, under what conditions?
Reply via ReviewNB
There was a problem hiding this comment.
Added some comments in the code. Please help to double check.
| @@ -0,0 +1,658 @@ | |||
| { | |||
There was a problem hiding this comment.
Line #2. df['NewScores'] = adj_scores_arr
Should we call out that the index needs to be unique? My understanding is that this will do a real JOIN in the SQL, so duplicate keys in the index might cause unexpected results.
Reply via ReviewNB
There was a problem hiding this comment.
Your understanding is correct. Added more comments in the code. Please double check.
ccb8f48 to
e172cf8
Compare
|
|
Thank you for opening a Pull Request! Before submitting your PR, there are a few things you can do to make sure it goes smoothly:
Fixes internal bug: 357587135 🦕