fix: remove a usage of the resource package when not available, such as on Windows#681
Merged
fix: remove a usage of the resource package when not available, such as on Windows#681
resource package when not available, such as on Windows#681Conversation
Collaborator
Author
|
I verified manually that |
TrevorBergeron
approved these changes
May 13, 2024
ashleyxuu
approved these changes
May 14, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Towards internal issue 339769193.
Note: I'm still working on getting a Windows Python dev environment setup, but this should address at least one known problem. I aim to follow-up with automated tests on Windows, too.
🦕