feat: Add transpose support for small homogeneously typed DataFrames.#621
Merged
TrevorBergeron merged 4 commits intomainfrom Apr 23, 2024
Merged
feat: Add transpose support for small homogeneously typed DataFrames.#621TrevorBergeron merged 4 commits intomainfrom
TrevorBergeron merged 4 commits intomainfrom
Conversation
milkshakeiii
approved these changes
Apr 22, 2024
Contributor
milkshakeiii
left a comment
There was a problem hiding this comment.
LGTM, just suggested we make it more clear in the docstrings exactly what the dtype restriction is.
|
|
||
| Reflect the DataFrame over its main diagonal by writing rows as columns | ||
| and vice-versa. The property :attr:`.T` is an accessor to the method | ||
| :meth:`transpose`. |
Contributor
There was a problem hiding this comment.
Can we add something here about the dtypes requirements? (Columns must be coerceable to a common type) (I know it's below but seems important enough to be up top.)
| ).all() | ||
|
|
||
|
|
||
| def test_df_transpose(): |
Contributor
There was a problem hiding this comment.
If it's a cheap test, we could add a check that we raise TypeError for mixing strs and floats.
bigframes/core/blocks.py
Outdated
| ) | ||
|
|
||
| def transpose(self) -> Block: | ||
| """Transpose the block. Will fail if dtypes incompatible or too many rows""" |
Contributor
There was a problem hiding this comment.
Suggest we change "dtypes incompatible" to "dtypes cannot be coerced all to a common type."
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Thank you for opening a Pull Request! Before submitting your PR, there are a few things you can do to make sure it goes smoothly:
Fixes #<issue_number_goes_here> 🦕