feat: add ARIMAPlus.coef_ property exposing ML.ARIMA_COEFFICIENTS functionality#585
Merged
tswast merged 18 commits intogoogleapis:mainfrom May 2, 2024
Merged
Conversation
…uery-dataframes into salem_timeseriessample
…es into salem_timeseriessample
tswast
reviewed
Apr 5, 2024
bigframes/ml/forecasting.py
Outdated
| options={"horizon": horizon, "confidence_level": confidence_level} | ||
| ) | ||
|
|
||
| def arima_coefficients( |
Collaborator
There was a problem hiding this comment.
We discussed exposing this as an @property called coef_ to match sklearn.
tswast
reviewed
Apr 22, 2024
bigframes/ml/core.py
Outdated
|
|
||
| return self._session.read_gbq(sql) | ||
|
|
||
| def coef_(self) -> bpd.DataFrame: |
Collaborator
There was a problem hiding this comment.
Let's use the SQL name here too.
ARIMAPlus.coef_ property exposing ML.ARIMA_COEFFICIENTS functionality
Collaborator
|
FYI: I updated the PR title to "feat: add Looks like the relevant tests are passing. :-) http://fusion2/ci/kokoro/prod%3Abigframes%2Fpresubmit%2Fe2e/activity/4cfd1e01-59bb-4955-8780-40c7fc914720 @GarrettWu @ashleyxuu The reason |
tswast
approved these changes
Apr 29, 2024
ashleyxuu
reviewed
May 1, 2024
tswast
requested changes
May 1, 2024
tswast
approved these changes
May 2, 2024
GarrettWu
approved these changes
May 2, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Thank you for opening a Pull Request! Before submitting your PR, there are a few things you can do to make sure it goes smoothly:
Fixes #<issue_number_goes_here> 🦕