feat: read_pandas accepts pandas Series and Index objects#573
Merged
gcf-merge-on-green[bot] merged 4 commits intomainfrom Apr 4, 2024
Merged
feat: read_pandas accepts pandas Series and Index objects#573gcf-merge-on-green[bot] merged 4 commits intomainfrom
gcf-merge-on-green[bot] merged 4 commits intomainfrom
Conversation
1b6087c to
8f1bea2
Compare
chelsea-lin
approved these changes
Apr 3, 2024
Contributor
chelsea-lin
left a comment
There was a problem hiding this comment.
minor comments. LGTM overall.
bigframes/pandas/__init__.py
Outdated
| read_gbq_table.__doc__ = inspect.getdoc(bigframes.session.Session.read_gbq_table) | ||
|
|
||
|
|
||
| @overload |
Contributor
There was a problem hiding this comment.
nit: using typing.overload.
| ... | ||
|
|
||
| def read_pandas( | ||
| self, pandas_dataframe: Union[pandas.DataFrame, pandas.Series, pandas.Index] |
Contributor
There was a problem hiding this comment.
Can we still have a break-change at current timing? Thinking to rename pandas_dataframe to data(or else).
Contributor
Author
There was a problem hiding this comment.
Yeah, the name is incorrect now, but I think its too late for breaking changes.
Genesis929
pushed a commit
that referenced
this pull request
Apr 9, 2024
Thank you for opening a Pull Request! Before submitting your PR, there are a few things you can do to make sure it goes smoothly: - [ ] Make sure to open an issue as a [bug/issue](https://togithub.com/googleapis/python-bigquery-dataframes/issues/new/choose) before writing your code! That way we can discuss the change, evaluate designs, and agree on the general idea - [ ] Ensure the tests and linter pass - [ ] Code coverage does not decrease (if any source code was changed) - [ ] Appropriate docs were updated (if necessary) Fixes #<issue_number_goes_here> 🦕
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Thank you for opening a Pull Request! Before submitting your PR, there are a few things you can do to make sure it goes smoothly:
Fixes #<issue_number_goes_here> 🦕