You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Thank you for opening a Pull Request! Before submitting your PR, there are a few things you can do to make sure it goes smoothly:
Make sure to open an issue as a bug/issue before writing your code! That way we can discuss the change, evaluate designs, and agree on the general idea
Ensure the tests and linter pass
Code coverage does not decrease (if any source code was changed)
Were any of these docstring or examples derived from the pandas documentation? If so, they need to be moved to third_party.
DataFrame.__array__ is one case that could be debated. There is no pandas DataFrame.__array__ documentation, so I put BigFrames DataFrame.__array__ directly. There is pandas Series.__array__, so I added BigFrames Series.__array__ in third party. For consistency I kept wording of DataFrame.__array__ close to Series.__array__.
Similarly for bunch of methods like __eq__, __ne__, __gt__ ... there is no pandas documentation but I am adding docstring with code samples directly in our classes which are worded similar to their public versions (eq, ne, gt respectively) for consistency.
adding docstring with code samples directly in our classes which are worded similar to their public versions
Anything derived from third-party content needs to be in the third-party directory.
Done.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
api: bigqueryIssues related to the googleapis/python-bigquery-dataframes API.size: xlPull request size is extra large.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
tswast
left a comment
Thank you for opening a Pull Request! Before submitting your PR, there are a few things you can do to make sure it goes smoothly:
__add__: https://screenshot.googleplex.com/8ZLiQJLZPTWEZdg__radd__: https://screenshot.googleplex.com/5Rn7Bn8guqBrBTDradd: https://screenshot.googleplex.com/C5KVoZCNTL9oiHqFixes internal issue 304747371 🦕