feat: option to use bq connection without check#460
Conversation
| self._bq_connection_id, | ||
| "run.invoker", | ||
| ) | ||
| if self._bq_connection_manager: |
There was a problem hiding this comment.
I would think of creating a dummy ConnectionManager class, and when skip_bq_connection_check is True, use the dummy implementation instead of a real one. Then the same logic can apply to all the places, and the user (of the connection_manager) doesn't need to think about the implementations.
Well just a suggestion, up to you.
There was a problem hiding this comment.
Um, gave it a thought, feels weird to implement a class with a method create_bq_connection which doesn't create anything. I'd prefer to not do that. Let me know if you have strong opinion about it.
There was a problem hiding this comment.
In that case we'd rename the create_bq_connection to sth like prepare_bq_connection.
No need to put too much thoughts on it. Just a suggestion.
BQ connection is currently used in BQ remote function and BQML Vertex AI integrations. It has a dependency on resource manager API, which is still going through the process of AXT compliance. We should provide a path in which BigFrames can work without resource manager interaction for the following two reasons:
Thank you for opening a Pull Request! Before submitting your PR, there are a few things you can do to make sure it goes smoothly:
Fixes internal issue 330224555 🦕