feat: (Series|DataFrame).plot.(line|area|scatter)#431
Merged
chelsea-lin merged 4 commits intomainfrom Mar 14, 2024
Merged
Conversation
b6eca40 to
276f228
Compare
| return ( | ||
| data.sample(n=sampling_n, random_state=sampling_random_state) | ||
| .to_pandas() | ||
| .sort_index() |
Contributor
There was a problem hiding this comment.
why is the sort necessary?
Contributor
Author
There was a problem hiding this comment.
the index of df.sample is not sorted as https://screenshot.googleplex.com/9nhptZFVA8sZJCz
36bd746 to
3dd4a19
Compare
TrevorBergeron
approved these changes
Mar 13, 2024
Contributor
TrevorBergeron
left a comment
There was a problem hiding this comment.
looks good, we can follow up later on how to preserve ordering when sampling
d792f25 to
b462808
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Internal bugs: