feat: Add dataframe.to_html#259
Merged
gcf-merge-on-green[bot] merged 6 commits intomainfrom Dec 28, 2023
Merged
Conversation
GarrettWu
reviewed
Dec 14, 2023
| assert bf_result == pd_result | ||
|
|
||
|
|
||
| def test_df_to_html(scalars_df_index, scalars_pandas_df_index): |
Contributor
There was a problem hiding this comment.
Can we add a test with all the input parameters. Then if pandas changes anything such as deprecating some arguments, we may know that and modify our docs.
Collaborator
Author
There was a problem hiding this comment.
There are way too many inputs, the test would be quite long after formatting. And on the other hand, based on how the to_html is defined on our end, if any argument is not longer available in pandas, I think an error will be raised in the test anyway, as we are passing all keyword arguments no matter whether there is an user input.
GarrettWu
approved these changes
Dec 21, 2023
| ) -> str: | ||
| return self.to_pandas().to_html( | ||
| buf, | ||
| columns, # type: ignore |
Contributor
There was a problem hiding this comment.
Prefer to cast explicitly instead of just ignore. Better readability.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Thank you for opening a Pull Request! Before submitting your PR, there are a few things you can do to make sure it goes smoothly:
Fixes b/296945119