Skip to content

docs: add examples for dataframe.min, dataframe.max and dataframe.sum#227

Merged
Genesis929 merged 4 commits intomainfrom
huanc-stats-docstring-2
Nov 23, 2023
Merged

docs: add examples for dataframe.min, dataframe.max and dataframe.sum#227
Genesis929 merged 4 commits intomainfrom
huanc-stats-docstring-2

Conversation

@Genesis929
Copy link
Collaborator

@Genesis929 Genesis929 commented Nov 22, 2023 •
edited
Loading

Thank you for opening a Pull Request! Before submitting your PR, there are a few things you can do to make sure it goes smoothly:

  • Make sure to open an issue as a bug/issue before writing your code! That way we can discuss the change, evaluate designs, and agree on the general idea
  • Ensure the tests and linter pass
  • Code coverage does not decrease (if any source code was changed)
  • Appropriate docs were updated (if necessary)

dataframe.min: https://screenshot.googleplex.com/6489Rd2d7TcbASP
dataframe.max: https://screenshot.googleplex.com/BhDnBqur8s2NnZv
dataframe.sum: https://screenshot.googleplex.com/ADGmxi7P58xWhNF
Fixes #<issue_number_goes_here> 🦕

@product-auto-label product-auto-label bot added size: m Pull request size is medium. api: bigquery Issues related to the googleapis/python-bigquery-dataframes API. labels Nov 22, 2023
@Genesis929 Genesis929 force-pushed the huanc-stats-docstring-2 branch from d4af37a to 3762c7b Compare November 22, 2023 04:37
@Genesis929 Genesis929 changed the title add examples for dataframe.min, dataframe.max and dataframe.sum docs: add examples for dataframe.min, dataframe.max and dataframe.sum Nov 22, 2023
@Genesis929 Genesis929 force-pushed the huanc-stats-docstring-2 branch from 3762c7b to ae69177 Compare November 22, 2023 05:04
@Genesis929 Genesis929 marked this pull request as ready for review November 22, 2023 05:14
@Genesis929 Genesis929 requested review from a team as code owners November 22, 2023 05:14
@Genesis929 Genesis929 requested a review from ashleyxuu November 22, 2023 05:14
shobsi
shobsi reviewed Nov 22, 2023
View reviewed changes
third_party/bigframes_vendored/pandas/core/frame.py Outdated
<BLANKLINE>
[2 rows x 2 columns]

Finding the maximum value in each column(the default behavior without an explicit axis parameter).
Copy link
Contributor

@shobsi shobsi Nov 22, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

space between a word and the parentheses "column(" -> "column ("

likewise other places

Copy link
Collaborator Author

@Genesis929 Genesis929 Nov 22, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done.

@Genesis929 Genesis929 merged commit 3a375e8 into main Nov 23, 2023
@Genesis929 Genesis929 deleted the huanc-stats-docstring-2 branch November 23, 2023 00:52
@release-please release-please bot mentioned this pull request Nov 23, 2023
Merged
Genesis929 added a commit that referenced this pull request Dec 12, 2023
@Genesis929
docs: add examples for dataframe.min, dataframe.max and dataframe.sum (…
fa2cb14 
…#227)

* docs: add examples for dataframe.min, dataframe.max and dataframe.sum

* update spacing
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@shobsi shobsi shobsi approved these changes

@ashleyxuu ashleyxuu Awaiting requested review from ashleyxuu ashleyxuu is a code owner automatically assigned from googleapis/api-bigquery-dataframe

Assignees

No one assigned

Labels

api: bigquery Issues related to the googleapis/python-bigquery-dataframes API. size: m Pull request size is medium.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@Genesis929 @shobsi