feat: support to_strip parameter for str.strip, str.lstrip and str.rstrip#1705
Merged
chelsea-lin merged 1 commit intomainfrom May 8, 2025
Merged
feat: support to_strip parameter for str.strip, str.lstrip and str.rstrip#1705chelsea-lin merged 1 commit intomainfrom
chelsea-lin merged 1 commit intomainfrom
Conversation
2c5153d to
bd54203
Compare
jialuoo
approved these changes
May 7, 2025
Contributor
|
One of the Kokoro doctest failed, please fix it first. |
bd54203 to
e162bcb
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This update introduces
to_stripparameters for thestr.strip,str.lstrip, andstr.rstripmethods. Additionally, it resolves an issue where newlines were not stripped whento_stripwas None, ensuring compatibility with pandas behavior.Fixes internal issue 416077777🦕