fix: fix bug with column names under repeated column assignment#150
Merged
gcf-merge-on-green[bot] merged 7 commits intomainfrom Oct 27, 2023
Merged
fix: fix bug with column names under repeated column assignment#150gcf-merge-on-green[bot] merged 7 commits intomainfrom
gcf-merge-on-green[bot] merged 7 commits intomainfrom
Conversation
TrevorBergeron
approved these changes
Oct 26, 2023
| new_column_block = local_df._block | ||
| original_index_column_ids = self._block.index_columns | ||
| self_block = self._block.reset_index(drop=False) | ||
| result_index, (get_column_left, get_column_right) = self_block.index.join( |
Contributor
There was a problem hiding this comment.
We should probably add some "join_by_offset" operator at some point as we do this kind of thing in a few places.
tswast
approved these changes
Oct 26, 2023
ashleyxuu
pushed a commit
that referenced
this pull request
Oct 30, 2023
Thank you for opening a Pull Request! Before submitting your PR, there are a few things you can do to make sure it goes smoothly: - [ ] Make sure to open an issue as a [bug/issue](https://togithub.com/googleapis/python-bigquery-dataframes/issues/new/choose) before writing your code! That way we can discuss the change, evaluate designs, and agree on the general idea - [ ] Ensure the tests and linter pass - [ ] Code coverage does not decrease (if any source code was changed) - [ ] Appropriate docs were updated (if necessary) Fixes #<issue_number_goes_here> 🦕
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Thank you for opening a Pull Request! Before submitting your PR, there are a few things you can do to make sure it goes smoothly:
Fixes #<issue_number_goes_here> 🦕