Skip to content

feat: add GeoSeries.difference() and bigframes.bigquery.st_difference()#1471

Merged
tswast merged 17 commits intomainfrom
b308738592-geopandas-difference
Mar 21, 2025
Merged

feat: add GeoSeries.difference() and bigframes.bigquery.st_difference()#1471
tswast merged 17 commits intomainfrom
b308738592-geopandas-difference

Conversation

@arwas11
Copy link
Contributor

@arwas11 arwas11 commented Mar 7, 2025

Thank you for opening a Pull Request! Before submitting your PR, there are a few things you can do to make sure it goes smoothly:

  • Make sure to open an issue as a bug/issue before writing your code! That way we can discuss the change, evaluate designs, and agree on the general idea
  • Ensure the tests and linter pass
  • Code coverage does not decrease (if any source code was changed)
  • Appropriate docs were updated (if necessary)

Fixes #<issue_number_goes_here> 🦕

@product-auto-label product-auto-label bot added size: m Pull request size is medium. api: bigquery Issues related to the googleapis/python-bigquery-dataframes API. labels Mar 7, 2025
@product-auto-label product-auto-label bot added size: l Pull request size is large. and removed size: m Pull request size is medium. labels Mar 11, 2025
@review-notebook-app
Copy link

review-notebook-app bot commented Mar 11, 2025

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.

Powered by ReviewNB

@arwas11 arwas11 requested a review from TrevorBergeron March 12, 2025 19:00
@arwas11 arwas11 marked this pull request as ready for review March 12, 2025 19:00
@arwas11 arwas11 requested review from a team as code owners March 12, 2025 19:00
@arwas11 arwas11 requested a review from tswast March 12, 2025 19:00
tswast
tswast reviewed Mar 18, 2025
View reviewed changes
@arwas11 arwas11 changed the title feat: add GeoSeries.difference() feat: add bigframes.geopandas.GeoSeries.difference() and bigframes.bigquery.st_difference()` Mar 20, 2025
@arwas11 arwas11 changed the title feat: add bigframes.geopandas.GeoSeries.difference() and bigframes.bigquery.st_difference()` feat: add bigframes.geopandas.GeoSeries.difference() and bigframes.bigquery.st_difference() Mar 20, 2025
@arwas11 arwas11 changed the title feat: add bigframes.geopandas.GeoSeries.difference() and bigframes.bigquery.st_difference() feat: add GeoSeries.difference() and bigquery.st_difference() Mar 20, 2025
@arwas11 arwas11 changed the title feat: add GeoSeries.difference() and bigquery.st_difference() feat: add GeoSeries.difference() and bigframes.bigquery.st_difference() Mar 20, 2025
@tswast
Copy link
Collaborator

tswast commented Mar 21, 2025

e2e failures:

FAILED tests/system/large/functions/test_managed_function.py::test_managed_function_series_apply[str]
FAILED tests/system/large/blob/test_function.py::test_blob_image_normalize_to_series
FAILED tests/system/large/blob/test_function.py::test_blob_image_blur_to_folder
FAILED tests/system/large/functions/test_managed_function.py::test_managed_function_series_apply_array_output[str]
FAILED tests/system/large/functions/test_managed_function.py::test_managed_function_array_output[bool]
FAILED tests/system/large/functions/test_managed_function.py::test_managed_function_series_apply[int]
FAILED tests/system/large/functions/test_managed_function.py::test_managed_function_dataframe_map_array_output
FAILED tests/system/large/functions/test_managed_function.py::test_managed_function_series_apply[bytes]
FAILED tests/system/large/blob/test_function.py::test_blob_image_normalize_to_folder
FAILED tests/system/large/blob/test_function.py::test_blob_image_resize_to_series
FAILED tests/system/large/blob/test_function.py::test_blob_image_blur_to_series
FAILED tests/system/large/functions/test_managed_function.py::test_managed_function_series_combine
FAILED tests/system/large/functions/test_managed_function.py::test_managed_function_series_apply[float]
FAILED tests/system/large/functions/test_managed_function.py::test_managed_function_dataframe_apply_axis_1
FAILED tests/system/large/functions/test_managed_function.py::test_managed_function_array_output[int]
FAILED tests/system/large/functions/test_managed_function.py::test_managed_function_series_apply_array_output[int]
FAILED tests/system/large/blob/test_function.py::test_blob_image_resize_to_folder
FAILED tests/system/large/functions/test_managed_function.py::test_managed_function_series_combine_array_output
FAILED tests/system/large/functions/test_managed_function.py::test_managed_function_series_apply[bool]
FAILED tests/system/large/functions/test_managed_function.py::test_managed_function_dataframe_apply_axis_1_array_output
FAILED tests/system/large/functions/test_managed_function.py::test_managed_function_array_output[float]
FAILED tests/system/large/functions/test_managed_function.py::test_managed_function_series_apply_array_output[float]

I'm not seeing anything geo-related, so I think these are all unrelated.

tswast
tswast approved these changes Mar 21, 2025
View reviewed changes
Copy link
Collaborator

@tswast tswast left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very cool!

@tswast tswast merged commit e9fe815 into main Mar 21, 2025
23 of 24 checks passed
@tswast tswast deleted the b308738592-geopandas-difference branch March 21, 2025 19:35
@release-please release-please bot mentioned this pull request Mar 21, 2025
Merged
shobsi pushed a commit that referenced this pull request Mar 28, 2025
@arwas11 @shobsi
feat: add GeoSeries.difference() and `bigframes.bigquery.st_differe…
e12c7d8 
…nce()` (#1471)

* feat: add GeoSeries.difference()

* add st_difference method and test cases for geo.difference and st_difference

* update method and tests

* update method and tests

* update test to cover different inputs

* update test assertion

* update testing with single geometry object and add notebook tag to ignore the exception

* fix docstrings

* modify geo_difference to make it available for use and update tests and notebook

* fix my py type error
@release-please release-please bot mentioned this pull request Mar 28, 2025
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@tswast tswast tswast approved these changes

@TrevorBergeron TrevorBergeron Awaiting requested review from TrevorBergeron

Assignees

@tswast tswast

Labels

api: bigquery Issues related to the googleapis/python-bigquery-dataframes API. size: l Pull request size is large.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@arwas11 @tswast