perf: Use simple null constraints to simplify queries#1381
Merged
TrevorBergeron merged 14 commits intomainfrom Feb 12, 2025
Merged
perf: Use simple null constraints to simplify queries#1381TrevorBergeron merged 14 commits intomainfrom
TrevorBergeron merged 14 commits intomainfrom
Conversation
GarrettWu
reviewed
Feb 12, 2025
bigframes/core/compile/compiled.py
Outdated
| import itertools | ||
| import typing | ||
| from typing import Optional, Sequence | ||
| from typing import Literal, Optional, Sequence, Tuple |
Contributor
There was a problem hiding this comment.
nit: if just use "tuple" for type annotation, then no need to import.
Contributor
Author
There was a problem hiding this comment.
fixed all Tuple and typing.Tuple for file
Collaborator
There was a problem hiding this comment.
We need to be careful about this kind of feedback. tuple typing subscripting wasn't added until 3.9 (see: https://docs.python.org/3/library/typing.html#typing.Tuple). Since bigframes dropped 3.8 pretty early on, this is OK, but please include links to what versions of Python syntax like this is supported in in your feedback next time.
| predicates=join_conditions, | ||
| how=type, # type: ignore | ||
| ) | ||
| combined_table = bigframes_vendored.ibis.join( |
GarrettWu
approved these changes
Feb 12, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Thank you for opening a Pull Request! Before submitting your PR, there are a few things you can do to make sure it goes smoothly:
Fixes #<issue_number_goes_here> 🦕