Skip to content

fix: dataframe sort_values Series input now raises keyerror.#1285

Merged
Genesis929 merged 2 commits intomainfrom
sort_values_fix_huanc
Jan 14, 2025
Merged

fix: dataframe sort_values Series input now raises keyerror.#1285
Genesis929 merged 2 commits intomainfrom
sort_values_fix_huanc

Conversation

@Genesis929
Copy link
Collaborator

Thank you for opening a Pull Request! Before submitting your PR, there are a few things you can do to make sure it goes smoothly:

  • Make sure to open an issue as a bug/issue before writing your code! That way we can discuss the change, evaluate designs, and agree on the general idea
  • Ensure the tests and linter pass
  • Code coverage does not decrease (if any source code was changed)
  • Appropriate docs were updated (if necessary)

Fixes #<issue_number_goes_here> 🦕

@product-auto-label product-auto-label bot added size: s Pull request size is small. api: bigquery Issues related to the googleapis/python-bigquery-dataframes API. labels Jan 14, 2025
@Genesis929 Genesis929 changed the title fix: dataframe sort_values Series input keyerror. fix: dataframe sort_values Series input now raises keyerror. Jan 14, 2025
@Genesis929 Genesis929 requested a review from tswast January 14, 2025 00:34
@Genesis929 Genesis929 marked this pull request as ready for review January 14, 2025 00:34
@Genesis929 Genesis929 requested review from a team as code owners January 14, 2025 00:34
@Genesis929 Genesis929 merged commit 5a2731b into main Jan 14, 2025
22 checks passed
@Genesis929 Genesis929 deleted the sort_values_fix_huanc branch January 14, 2025 21:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

api: bigquery Issues related to the googleapis/python-bigquery-dataframes API. size: s Pull request size is small.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants