feat: (Series | DataFrame).plot.bar#1152
Merged
chelsea-lin merged 5 commits intomainfrom Nov 21, 2024
Merged
Conversation
47a02f4 to
aa1ecb0
Compare
Comment on lines
+84
to
+100
| class BarPlot(SamplingPlot): | ||
| @property | ||
| def _kind(self) -> typing.Literal["bar"]: | ||
| return "bar" |
Contributor
There was a problem hiding this comment.
Does bar plot make sense as a sampling plot? It seems that bar plots are really meant for small-cardinalities and don't down-sample well.
Contributor
Author
There was a problem hiding this comment.
The bar plots are discrete while the area/line/scatter plots are continuous. Hence, the downsampling in the bar is not straightforward compared to others. Thanks for suggestions here. I just added a warning message to suggest users to consider pre-processing data (aggregations or select top categories).
5ce55f0 to
86de62c
Compare
TrevorBergeron
approved these changes
Nov 20, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes internal issue 375905303🦕