Skip to content

Conversation

@BenWhitehead
Copy link
Collaborator

  • GoogleManagedEncryptionEnforcementConfig
  • CustomerManagedEncryptionEnforcementConfig
  • CustomerSuppliedEncryptionEnforcementConfig

@BenWhitehead BenWhitehead requested a review from a team as a code owner July 23, 2025 16:14
@BenWhitehead BenWhitehead requested a review from a team July 23, 2025 16:14
@product-auto-label product-auto-label bot added size: l Pull request size is large. api: storage Issues related to the googleapis/java-storage API. labels Jul 23, 2025
* GoogleManagedEncryptionEnforcementConfig
* CustomerManagedEncryptionEnforcementConfig
* CustomerSuppliedEncryptionEnforcementConfig
@BenWhitehead BenWhitehead force-pushed the feat/bucket-encryption-config branch from 122f35c to 67baf14 Compare July 23, 2025 16:40
BrandonY
BrandonY previously approved these changes Aug 4, 2025
GoogleManagedEncryptionEnforcementConfig,
Encryption.GoogleManagedEncryptionEnforcementConfig>
googleManagedEncryptionEnforcementConfigCodec =
Codec.of(
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This stuff seems very boilerplate. I wonder if there's a good way to pare it down or make more in common with the other methods. Probably nothing to do about it just now, so just an observation.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It is. Unfortunately, the types we are touching are grpc generated and apiary generated classes. Which have the same shape, but none of the shared common class hierarchy. We'd either need what we have here, or some facade that was able to sit over both and make this code easier, but that facade would need to do some translation/mapping itself. So, while not ideal by an abstraction perspective, the conversions classes are at least mostly self contained and low maintenance once the conversions are added.

@BenWhitehead BenWhitehead merged commit 7b250dd into main Aug 5, 2025
25 checks passed
@BenWhitehead BenWhitehead deleted the feat/bucket-encryption-config branch August 5, 2025 16:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

api: storage Issues related to the googleapis/java-storage API. size: l Pull request size is large.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants