feat: Enable Lossless Timestamps in BQ java client lib#3589
Merged
whuffman36 merged 4 commits intomainfrom Dec 2, 2024
Merged
Conversation
PhongChuong
reviewed
Nov 25, 2024
Contributor
PhongChuong
left a comment
There was a problem hiding this comment.
Overall looks good. Just a few minor comments/change requests.
google-cloud-bigquery/src/main/java/com/google/cloud/bigquery/QueryJobConfiguration.java
Show resolved
Hide resolved
google-cloud-bigquery/src/test/java/com/google/cloud/bigquery/it/ITBigQueryTest.java
Outdated
Show resolved
Hide resolved
google-cloud-bigquery/src/test/java/com/google/cloud/bigquery/it/ITBigQueryTest.java
Outdated
Show resolved
Hide resolved
google-cloud-bigquery/src/main/java/com/google/cloud/bigquery/FieldValue.java
Show resolved
Hide resolved
google-cloud-bigquery/src/main/java/com/google/cloud/bigquery/BigQueryOptions.java
Show resolved
Hide resolved
google-cloud-bigquery/src/test/java/com/google/cloud/bigquery/QueryRequestInfoTest.java
Outdated
Show resolved
Hide resolved
PhongChuong
approved these changes
Dec 2, 2024
This was referenced Dec 17, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
With discovery revision 20240124 or later, the BQ discovery document now properly exposes the API functionality to use lossless timestamps (DataFormatOptions.UseInt64Timestamp). This can be supplied as part of the jobs.query request, as well as passed as arguments to tabledata.list / jobs.getQueryResults.
This change enables the toggling of lossless timestamps in the java client library for BQ. The former format is still usable and is used by default. Users must opt in to use this feature.