Add an improved backend for the Cause search by danniel · Pull Request #658 · code4romania/redirectioneaza

danniel · 2026-02-20T07:18:44Z

No description provided.

greptile-apps · 2026-02-20T07:21:12Z

Greptile Summary

Replaces NgoCauseMixedSearchMixin with new ImprovedCauseSearchMixin that adds exact match search with registration number lookup fallback before fuzzy search.

Key Changes:

Adds probable_registration_number() helper to detect and parse registration numbers (supports RO prefix and numeric-only formats)
New ImprovedCauseSearchMixin implements two-tier search: exact match first (by name or registration number), then fuzzy search if no exact matches found
Registration number search specifically targets main causes (is_main=True) associated with matching NGOs
Controlled by new ENABLE_CAUSE_SEARCH_EXACT_MATCH feature flag (defaults to True)
Applied to both SearchCausesApi and NgoListHandler views

Confidence Score: 4/5

Safe to merge with minor optimization opportunity
Code is well-structured with proper feature flag control and follows existing patterns, but has one non-critical performance issue using len() on QuerySet instead of .exists()
backend/donations/views/common/search.py - consider optimizing QuerySet evaluation on line 156

Important Files Changed

Filename	Overview
backend/donations/views/common/search.py	Adds `probable_registration_number()` helper and new `ImprovedCauseSearchMixin` with exact match fallback and registration number search
backend/donations/views/api.py	Updates `SearchCausesApi` to use `ImprovedCauseSearchMixin` instead of `NgoCauseMixedSearchMixin`
backend/donations/views/site.py	Updates `NgoListHandler` to use `ImprovedCauseSearchMixin` instead of `NgoCauseMixedSearchMixin`
backend/redirectioneaza/settings/feature_flags.py	Adds `ENABLE_CAUSE_SEARCH_EXACT_MATCH` feature flag defaulting to `True`

Flowchart

%%{init: {'theme': 'neutral'}}%%
flowchart TD
    A[User Search Query] --> B[ImprovedCauseSearchMixin.get_search_results]
    B --> C{ENABLE_CAUSE_SEARCH_EXACT_MATCH?}
    C -->|Yes| D[Build Exact Match Filter]
    D --> E[name__icontains query]
    D --> F{Query looks like registration number?}
    F -->|Yes| G[probable_registration_number helper]
    G --> H{Starts with RO + numeric?}
    G --> I{Only numeric?}
    H -->|Yes| J[Extract numeric part]
    I -->|Yes| K[Use as-is]
    J --> L[Add filter: ngo__registration_number + is_main=True]
    K --> L
    F -->|No| M[Execute exact_causes query]
    L --> M
    E --> M
    M --> N{Has exact matches?}
    N -->|Yes| O[Return exact matches]
    N -->|No| P[Fall through to fuzzy search]
    C -->|No| P
    P --> Q[Build SearchVector + SearchQuery]
    Q --> R{ENABLE_CAUSE_SEARCH_WORD_SIMILARITY?}
    R -->|Yes| S[Use TrigramWordSimilarity threshold 0.4]
    R -->|No| T[Use TrigramSimilarity threshold 0.3]
    S --> U[Execute fuzzy_causes query]
    T --> U
    U --> V[Return fuzzy results]
    O --> W[Return to API/View]
    V --> W

_{Last reviewed commit: 4b5a501}

greptile-apps

_{4 files reviewed, 1 comment}

_{Edit Code Review Agent Settings | Greptile}