feat(tanstackstart-react)!: Export Vite plugin from @sentry/tanstackstart-react/vite subpath#19182
Conversation
…tart-react/vite subpath
Codecov Results 📊Generated by Codecov Action |
andreiborza
left a comment
There was a problem hiding this comment.
Could you also update the e2e test app to use the latest nitro (the one that create tanstack start app uses) please?
| "react": "^19.2.0", | ||
| "react-dom": "^19.2.0" | ||
| "react-dom": "^19.2.0", | ||
| "nitro": "npm:nitro-nightly@latest" |
There was a problem hiding this comment.
Can you please update the PR description to highlight why we are doing this so that in 2 months when we see this again and wonder what the hell... we will at least find the justification on github 😅
|
I put this in draft because we are still trying to figure out how to replicate the issue in our e2e tests before making sure this fixes anything, as it's a breaking change 😅 |
node-overhead report 🧳Note: This is a synthetic benchmark with a minimal express app and does not necessarily reflect the real-world performance impact in an application.
|
size-limit report 📦
|
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes and found 1 potential issue.
Bugbot Autofix is OFF. To automatically fix reported issues with Cloud Agents, enable Autofix in the Cursor dashboard.
Closes #19180
Closes #19181
Context #19142
As discussed we change the
sentryTanstackStart()vite plugin to now be a subpath export from@sentry/tanstackstart-react. This should resolve the issue of the plugin being pulled into user builds. As far as I could see this now seems to work for the latest nitro alpha. With the latest nitro nightly we still see arollupissue that is a bit annoying. However, it does work with the latest vite 8 beta, which usesrolldown.