Skip to content

Comments

feat(tanstackstart-react)!: Export Vite plugin from @sentry/tanstackstart-react/vite subpath#19182

Merged
nicohrubec merged 9 commits intodevelopfrom
nh/tss-vite-plugin-subpath-export
Feb 23, 2026
Merged

feat(tanstackstart-react)!: Export Vite plugin from @sentry/tanstackstart-react/vite subpath#19182
nicohrubec merged 9 commits intodevelopfrom
nh/tss-vite-plugin-subpath-export

Conversation

@nicohrubec
Copy link
Member

@nicohrubec nicohrubec commented Feb 5, 2026

Closes #19180
Closes #19181

Context #19142

As discussed we change the sentryTanstackStart() vite plugin to now be a subpath export from @sentry/tanstackstart-react. This should resolve the issue of the plugin being pulled into user builds. As far as I could see this now seems to work for the latest nitro alpha. With the latest nitro nightly we still see a rollup issue that is a bit annoying. However, it does work with the latest vite 8 beta, which uses rolldown.

@nicohrubec nicohrubec marked this pull request as ready for review February 5, 2026 12:29
@github-actions
Copy link
Contributor

github-actions bot commented Feb 5, 2026

Codecov Results 📊


Generated by Codecov Action

Copy link
Member

@andreiborza andreiborza left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you also update the e2e test app to use the latest nitro (the one that create tanstack start app uses) please?

"react": "^19.2.0",
"react-dom": "^19.2.0"
"react-dom": "^19.2.0",
"nitro": "npm:nitro-nightly@latest"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you please update the PR description to highlight why we are doing this so that in 2 months when we see this again and wonder what the hell... we will at least find the justification on github 😅

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yes of course 😆

@andreiborza
Copy link
Member

I put this in draft because we are still trying to figure out how to replicate the issue in our e2e tests before making sure this fixes anything, as it's a breaking change 😅

@github-actions
Copy link
Contributor

node-overhead report 🧳

Note: This is a synthetic benchmark with a minimal express app and does not necessarily reflect the real-world performance impact in an application.

Scenario Requests/s % of Baseline Prev. Requests/s Change %
GET Baseline 8,881 - 10,685 -17%
GET With Sentry 1,622 18% 1,727 -6%
GET With Sentry (error only) 6,054 68% 7,390 -18%
POST Baseline 1,199 - 1,054 +14%
POST With Sentry 591 49% 528 +12%
POST With Sentry (error only) 1,033 86% 975 +6%
MYSQL Baseline 3,163 - 3,942 -20%
MYSQL With Sentry 470 15% 408 +15%
MYSQL With Sentry (error only) 2,610 83% 3,097 -16%

View base workflow run

@nicohrubec nicohrubec self-assigned this Feb 20, 2026
@github-actions
Copy link
Contributor

github-actions bot commented Feb 23, 2026

size-limit report 📦

Path Size % Change Change
@sentry/browser 25.62 kB - -
@sentry/browser - with treeshaking flags 24.12 kB - -
@sentry/browser (incl. Tracing) 42.42 kB - -
@sentry/browser (incl. Tracing, Profiling) 47.09 kB - -
@sentry/browser (incl. Tracing, Replay) 81.24 kB - -
@sentry/browser (incl. Tracing, Replay) - with treeshaking flags 70.86 kB - -
@sentry/browser (incl. Tracing, Replay with Canvas) 85.94 kB - -
@sentry/browser (incl. Tracing, Replay, Feedback) 98.2 kB - -
@sentry/browser (incl. Feedback) 42.43 kB - -
@sentry/browser (incl. sendFeedback) 30.29 kB - -
@sentry/browser (incl. FeedbackAsync) 35.34 kB - -
@sentry/browser (incl. Metrics) 26.79 kB - -
@sentry/browser (incl. Logs) 26.93 kB - -
@sentry/browser (incl. Metrics & Logs) 27.61 kB - -
@sentry/react 27.37 kB - -
@sentry/react (incl. Tracing) 44.76 kB - -
@sentry/vue 30.07 kB - -
@sentry/vue (incl. Tracing) 44.27 kB - -
@sentry/svelte 25.64 kB - -
CDN Bundle 28.16 kB - -
CDN Bundle (incl. Tracing) 43.25 kB - -
CDN Bundle (incl. Logs, Metrics) 29 kB - -
CDN Bundle (incl. Tracing, Logs, Metrics) 44.09 kB - -
CDN Bundle (incl. Replay, Logs, Metrics) 68.08 kB - -
CDN Bundle (incl. Tracing, Replay) 80.13 kB - -
CDN Bundle (incl. Tracing, Replay, Logs, Metrics) 81 kB - -
CDN Bundle (incl. Tracing, Replay, Feedback) 85.65 kB - -
CDN Bundle (incl. Tracing, Replay, Feedback, Logs, Metrics) 86.53 kB - -
CDN Bundle - uncompressed 82.34 kB - -
CDN Bundle (incl. Tracing) - uncompressed 128.06 kB - -
CDN Bundle (incl. Logs, Metrics) - uncompressed 85.18 kB - -
CDN Bundle (incl. Tracing, Logs, Metrics) - uncompressed 130.89 kB - -
CDN Bundle (incl. Replay, Logs, Metrics) - uncompressed 208.84 kB - -
CDN Bundle (incl. Tracing, Replay) - uncompressed 244.94 kB - -
CDN Bundle (incl. Tracing, Replay, Logs, Metrics) - uncompressed 247.76 kB - -
CDN Bundle (incl. Tracing, Replay, Feedback) - uncompressed 257.85 kB - -
CDN Bundle (incl. Tracing, Replay, Feedback, Logs, Metrics) - uncompressed 260.66 kB - -
@sentry/nextjs (client) 47.17 kB - -
@sentry/sveltekit (client) 42.89 kB - -
@sentry/node-core 52.18 kB +0.02% +8 B 🔺
@sentry/node 173.45 kB +0.01% +9 B 🔺
@sentry/node - without tracing 97.33 kB +0.01% +9 B 🔺
@sentry/aws-serverless 113.13 kB +0.01% +7 B 🔺

View base workflow run

@nicohrubec nicohrubec marked this pull request as ready for review February 23, 2026 13:21
Copy link

@cursor cursor bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cursor Bugbot has reviewed your changes and found 1 potential issue.

Bugbot Autofix is OFF. To automatically fix reported issues with Cloud Agents, enable Autofix in the Cursor dashboard.

@nicohrubec nicohrubec merged commit 11e5412 into develop Feb 23, 2026
37 checks passed
@nicohrubec nicohrubec deleted the nh/tss-vite-plugin-subpath-export branch February 23, 2026 14:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Update Tanstack Start e2e app nitro dependency to latest Make sentryTanstackStart vite plugin a subpath export

2 participants